Skip to content

Implemented redirects from redirector app shoud include all query str…#3070

Merged
RamiroAlvaro merged 1 commit intomasterfrom
3066
Oct 13, 2020
Merged

Implemented redirects from redirector app shoud include all query str…#3070
RamiroAlvaro merged 1 commit intomasterfrom
3066

Conversation

@RamiroAlvaro
Copy link
Copy Markdown
Contributor

…ing data on redirect

close #3066

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 9, 2020

Codecov Report

Merging #3070 into master will decrease coverage by 0.02%.
The diff coverage is 95.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3070      +/-   ##
==========================================
- Coverage   95.48%   95.46%   -0.03%     
==========================================
  Files         209      214       +5     
  Lines        6023     6171     +148     
==========================================
+ Hits         5751     5891     +140     
- Misses        272      280       +8     
Impacted Files Coverage Δ
pythonpro/analytics/apps.py 0.00% <0.00%> (ø)
...dules/tests/test_module_index_view_roles_access.py 100.00% <ø> (ø)
pythonpro/pages/urls.py 100.00% <ø> (ø)
pythonpro/checkout/tests/conftest.py 77.77% <50.00%> (-2.23%) ⬇️
pythonpro/domain/tests/test_checkout/conftest.py 82.85% <50.00%> (-2.00%) ⬇️
pythonpro/analytics/tests/conftest.py 97.36% <75.00%> (-2.64%) ⬇️
pythonpro/analytics/context_processors.py 100.00% <100.00%> (ø)
...ro/analytics/migrations/0002_auto_20201007_1518.py 100.00% <100.00%> (ø)
pythonpro/analytics/models.py 95.83% <100.00%> (ø)
pythonpro/analytics/tests/test_models.py 100.00% <100.00%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de5fab5...1f173be. Read the comment docs.

@renzon
Copy link
Copy Markdown
Member

renzon commented Oct 13, 2020

This code is ok, only missing a rebase onto master merge and deploy it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redirects from redirector app shoud include all query string data on redirect

2 participants